fix: Unable to edit time_bound access codes #656
Conversation
| @@ -173,7 +173,7 @@ function Content({ | |||
| : null | |||
|
|
|||
| const hasCodeInputs = | |||
| accessCode?.type !== 'time_bound' || accessCode.is_offline_access_code | |||
| accessCode?.type !== 'time_bound' && accessCode?.is_offline_access_code | |||
There was a problem hiding this comment.
Won't this new condition mean that the UI will only allow editing offline access codes? What about editing online access codes?
There was a problem hiding this comment.
There was a problem hiding this comment.
@mastafit I am looking at the thread, but it doesn't answer my original question. Can you answer my original question per the intent of this change?
There was a problem hiding this comment.
@razor-x You are right, I think we can add extra conditions
There was a problem hiding this comment.
I mean remove the extra condition, something like that:
const hasCodeInputs = accessCode?.type !== 'time_bound'
There was a problem hiding this comment.
@mastafit This might help.
Code inputs were intentionally hidden for offline codes: #606
But the current (and updated) logic also hides it for other code kinds. That appears like a mistake. What if we only hide the inputs when for the offline code case?
const hasCodeInputs = accessCode.is_offline_access_code !== ture
There was a problem hiding this comment.
Makes sense, I have updated the code!
| if (start === null || start === undefined) { | ||
| throw new Error(`Invalid start date: ${startDate.invalidReason}`) | ||
| } |
There was a problem hiding this comment.
| if (start === null || start === undefined) { | |
| throw new Error(`Invalid start date: ${startDate.invalidReason}`) | |
| } | |
| if (start === null) { | |
| throw new Error(`Invalid start date: ${startDate.invalidReason}`) | |
| } |
| throw new Error(`Invalid start date: ${startDate.invalidReason}`) | ||
| } | ||
|
|
||
| const end = endDate.toISO() | ||
| if (end == null) { | ||
| if (end === null || end === undefined) { |
There was a problem hiding this comment.
| if (end === null || end === undefined) { | |
| if (end === null) { |
| {hasCodeInputs !== null && | ||
| hasCodeInputs !== undefined && | ||
| hasCodeInputs && ( |
There was a problem hiding this comment.
| {hasCodeInputs !== null && | |
| hasCodeInputs !== undefined && | |
| hasCodeInputs && ( | |
| {hasCodeInputs && ( |
There was a problem hiding this comment.
Yes, it's redundant, I have removed it now
razor-x
changed the title
razor-x
deleted the
andriitymofieiev/shd-178-time-bound-access-code-is-not-able-to-being-edit
branch
No description provided.